Merged
Conversation
thewhaleking
approved these changes
Nov 6, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Interesting approach.
ibraheem-abe
approved these changes
Nov 6, 2024
Collaborator
Author
yeah, I thought it was a working approach too. but ultimately i have some thoughts on how to rework the verification mechanism for |
ppolewicz
reviewed
Nov 6, 2024
Comment on lines
+688
to
+689
| if network in settings.NETWORKS: | ||
| return network, settings.NETWORK_MAP[network] |
Contributor
There was a problem hiding this comment.
Suggested change
| if network in settings.NETWORKS: | |
| return network, settings.NETWORK_MAP[network] | |
| if chain_endpoint := settings.NETWORK_MAP.get(network): | |
| return network, chain_endpoint |
Collaborator
Author
There was a problem hiding this comment.
we check the network argument before chain_endpoint if defined
Comment on lines
51
to
55
| NETWORK_MAP = { | ||
| NETWORKS[0]: FINNEY_ENTRYPOINT, | ||
| NETWORKS[1]: FINNEY_TEST_ENTRYPOINT, | ||
| NETWORKS[2]: ARCHIVE_ENTRYPOINT, | ||
| NETWORKS[3]: LOCAL_ENTRYPOINT, |
Contributor
There was a problem hiding this comment.
Suggested change
| NETWORK_MAP = { | |
| NETWORKS[0]: FINNEY_ENTRYPOINT, | |
| NETWORKS[1]: FINNEY_TEST_ENTRYPOINT, | |
| NETWORKS[2]: ARCHIVE_ENTRYPOINT, | |
| NETWORKS[3]: LOCAL_ENTRYPOINT, | |
| NETWORK_MAP = { | |
| "finney": FINNEY_ENTRYPOINT, | |
| "test": FINNEY_TEST_ENTRYPOINT, | |
| "archive": ARCHIVE_ENTRYPOINT, | |
| "local": LOCAL_ENTRYPOINT, | |
| "subvortex": SUBVORTEX_ENTRYPOINT, | |
| } |
and later
NETWORKS = NETWORK_MAP.keys()
Normally I'd refactor the module to not use NETWORKS at all, but someone might be using it in subnet code, so lets leave it. One day when the interface is documented we can clean it up.
ibraheem-abe
pushed a commit
that referenced
this pull request
Nov 6, 2024
Merged
basfroman
added a commit
that referenced
this pull request
Nov 13, 2024
* Expands the type registry to include all the available options (#2353) Expands the type registry to include all the available options * add `Subtensor.register`, `Subtensor.difficulty` and related staff with tests (#2352) * add `bittensor.core.subtensor.Subtensor.register`, `bittensor.core.subtensor.Subtensor.difficulty` and related staff with tests * remove commented code * update `_terminate_workers_and_wait_for_exit` by review * added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics (#2359) * added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics * formatter * Update bittensor/core/extrinsics/registration.py Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> --------- Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> * Poem "Risen from the Past". Act 3. (#2363) * add `get_delegate_by_hotkey`, update `DelegateInfo` in chain data * add `root_register_extrinsic`, `set_root_weights_extrinsic` and related stuff * add `Subtensor.get_all_subnets_info` method and related stuff * add `Subtensor.get_delegate_take` method and tests * ruff * remove unused import * default port from 9946 to 9944 (#2376) * remove unused prometheus extrinsic (#2378) * Replace rich.console to btlogging.loggin (#2377) * replace `rich.console` to `btlogging.logging` * update requirements * use whole path import * fix some logging * fix registration.py * ruff * del prometheus.py * fix review comments * Merge pull request #2382 from opentensor/feat/roman/remove-prompt-from-sdk Avoid using `prompt` in SDK * Handle SSL Error on Connection (#2384) * Add `subvortex` subnet and tests (#2395) * add `subvortex` subnet and tests * ruff * Bumps version and updates changelog --------- Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <165814940+ibraheem-opentensor@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <ibraheem@opentensor.dev>
thewhaleking
added a commit
that referenced
this pull request
Nov 14, 2024
* Expands the type registry to include all the available options (#2353) Expands the type registry to include all the available options * add `Subtensor.register`, `Subtensor.difficulty` and related staff with tests (#2352) * add `bittensor.core.subtensor.Subtensor.register`, `bittensor.core.subtensor.Subtensor.difficulty` and related staff with tests * remove commented code * update `_terminate_workers_and_wait_for_exit` by review * added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics (#2359) * added to Subtensor: `burned_register`, `get_subnet_burn_cost`, `recycle` and related extrinsics * formatter * Update bittensor/core/extrinsics/registration.py Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> --------- Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> * Poem "Risen from the Past". Act 3. (#2363) * add `get_delegate_by_hotkey`, update `DelegateInfo` in chain data * add `root_register_extrinsic`, `set_root_weights_extrinsic` and related stuff * add `Subtensor.get_all_subnets_info` method and related stuff * add `Subtensor.get_delegate_take` method and tests * ruff * remove unused import * default port from 9946 to 9944 (#2376) * remove unused prometheus extrinsic (#2378) * Replace rich.console to btlogging.loggin (#2377) * replace `rich.console` to `btlogging.logging` * update requirements * use whole path import * fix some logging * fix registration.py * ruff * del prometheus.py * fix review comments * Merge pull request #2382 from opentensor/feat/roman/remove-prompt-from-sdk Avoid using `prompt` in SDK * Handle SSL Error on Connection (#2384) * Add `subvortex` subnet and tests (#2395) * add `subvortex` subnet and tests * ruff * Bumps version and updates changelog * bumping up version * Update CHANGELOG.md * bumping version * Update CHANGELOG.md with 8.3.1 * update docker version in config.yml * update docker version in config.yml * remove docker job in config.yml * remove docker job in config.yml 2 --------- Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <165814940+ibraheem-opentensor@users.noreply.github.com> Co-authored-by: ibraheem-opentensor <ibraheem@opentensor.dev> Co-authored-by: Roman <roman@opentensor.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.